Don't panic on missing binds in insert_split#1181
Merged
Merged
Conversation
The code on the old parser, surprisingly, treated this operation as infallible, and just sent an incorrect number of parameters to the shards (which given that we don't behave transactionally for split inserts, could lead to a partial insert). This doesn't fix the lack of transactional behavior, but at least in the new port we won't send any rows at all if we don't have enough bind parameters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
meskill
reviewed
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code on the old parser, surprisingly, treated this operation as infallible, and just sent an incorrect number of parameters to the shards (which given that we don't behave transactionally for split inserts, could lead to a partial insert). This doesn't fix the lack of transactional behavior, but at least in the new port we won't send any rows at all if we don't have enough bind parameters